Skip to content

Release 5.2.6#2200

Merged
fredericDelaporte merged 1 commit into
nhibernate:5.2.xfrom
fredericDelaporte:Release5.2.6
Sep 8, 2019
Merged

Release 5.2.6#2200
fredericDelaporte merged 1 commit into
nhibernate:5.2.xfrom
fredericDelaporte:Release5.2.6

Conversation

@fredericDelaporte
Copy link
Copy Markdown
Member

@fredericDelaporte fredericDelaporte commented Aug 25, 2019

Preparing the release. It currently accounts for pending PRs, async update and dependent transaction fix. If some of them are discarded or delayed to another release, this PR will have to be updated accordingly.

As written by @bahusoid here, some care should be taken when merging to master after the release:

When merging to master this change should be ignored. The following code is expected in master (no need to wrap in new List):

queryInfo.ResultToCache = queryCacheBuilder.Result;

@fredericDelaporte fredericDelaporte added this to the 5.2.6 milestone Aug 25, 2019
hazzik
hazzik reviewed Sep 2, 2019
View reviewed changes
Comment thread releasenotes.txt Outdated
@fredericDelaporte
Copy link
Copy Markdown
Member Author

fredericDelaporte commented Sep 5, 2019

Rebased, I will likely release it next Sunday.

@fredericDelaporte fredericDelaporte merged commit f7b64c5 into nhibernate:5.2.x Sep 8, 2019
@fredericDelaporte fredericDelaporte deleted the Release5.2.6 branch September 8, 2019 11:57
@fredericDelaporte
Copy link
Copy Markdown
Member Author

fredericDelaporte commented Sep 8, 2019

#2111, in this release, has updated the documentation. But I do not intend to update it on nhibernate.info yet, because it is about a new feature, while we only publish minor version of the documentation, not release version. So updating the 5.2 documentation could be confusing for those attempting to use the feature with a 5.2.5 or below version of NHibernate. I think it should wait 5.3.

@oskarb
Copy link
Copy Markdown
Member

oskarb commented Sep 8, 2019

#2111, in this release, has updated the documentation. But I do not intend to update it on nhibernate.info yet, because it is about a new feature, while we only publish minor version of the documentation, not release version. So updating the 5.2 documentation could be confusing for those attempting to use the feature with a 5.2.5 or below version of NHibernate. I think it should wait 5.3.

I agree - especially given that it was most likely for a really narrow use case anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hazzik hazzik hazzik approved these changes

Assignees

No one assigned

Labels

c: Documentation p: Minor r: Fixed t: Task

Projects

None yet

Milestone

5.2.6

Development

Successfully merging this pull request may close these issues.

3 participants

@fredericDelaporte @oskarb @hazzik